Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1142 but only contain the fixes #1189

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

#1142 but only contain the fixes #1189

wants to merge 11 commits into from

Conversation

MasedMSD
Copy link
Collaborator

@MasedMSD MasedMSD commented Feb 9, 2025

I apologise if the PR is incorrect. It was based on #1142 (comment).
I may not have transferred all the fixes, or I may have transferred unnecessary ones. Please consider this PR

@MasedMSD MasedMSD requested a review from KnorpelSenf February 9, 2025 17:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025 •
edited
Loading

🚀 Deployed on https://67b5fc2d51dc12232ea9b3bc--grammy.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 9, 2025 17:35 Inactive
roziscoding
roziscoding requested changes Feb 10, 2025
View reviewed changes
@github-actions github-actions bot temporarily deployed to pull request February 10, 2025 17:49 Inactive
carafelix
carafelix requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@carafelix carafelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my comments may fall somewhat outside the scope of this specific pr, but I think are worth noting.

@github-actions github-actions bot temporarily deployed to pull request February 11, 2025 15:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 12, 2025 17:09 Inactive
@MasedMSD
Copy link
Collaborator Author

Some of my comments may fall somewhat outside the scope of this specific pr, but I think are worth noting.

Applied all suggestions. LGTM from now

@github-actions github-actions bot temporarily deployed to pull request February 17, 2025 11:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 17, 2025 18:10 Inactive
carafelix
carafelix approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@carafelix carafelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the space thing. LGTM

@github-actions github-actions bot temporarily deployed to pull request February 18, 2025 12:43 Inactive
KnorpelSenf
KnorpelSenf approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@MasedMSD MasedMSD requested a review from roziscoding February 18, 2025 14:58
@MasedMSD
Copy link
Collaborator Author

Finally this docs gonna be fixed 🎉

@github-actions github-actions bot temporarily deployed to pull request February 18, 2025 18:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

@roziscoding roziscoding roziscoding approved these changes

@carafelix carafelix carafelix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MasedMSD @roziscoding @KnorpelSenf @carafelix @LWJerri