Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizon: Integration tests #1109

Draft
wants to merge 20 commits into
base: horizon
Choose a base branch
from
Draft

Horizon: Integration tests #1109

wants to merge 20 commits into from

Conversation

Maikol
Copy link
Member

@Maikol Maikol commented Feb 12, 2025

No description provided.

Copy link

openzeppelin-code bot commented Feb 12, 2025

Horizon: Integration tests

Generated at commit: c40fd3c3cdb5c9e115030d2569874c2a0ac97424

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@Maikol Maikol changed the title Mde/integration tests Horizon: Integration tests Feb 14, 2025
@Maikol Maikol force-pushed the mde/integration-tests branch from c867b19 to 85b87a2 Compare February 21, 2025 22:24
Copy link

socket-security bot commented Feb 21, 2025

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@Maikol Maikol force-pushed the mde/integration-tests branch from 97bdc54 to fb7c116 Compare March 10, 2025 16:52
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is gonna suck but I think we need to rebase the PR on top of tmigone/horizon-post-oz-audit2. I introduced several changes to the tooling there including changing how this file is structured. I don't mind doing the rebase after you are done addressing the other comments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, what's most painful is the change in tests folder structure but I can do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it once we have this PR finalized, it's fair since I created that other branch after you started this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also cover the flows in the explorer and indexer-agent as those will be the most common ones. Probably using multicall. I can submit a PR with those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding more notes to myself mostly, don't worry about this for this PR:

  • Delegation parameter config multicall tx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants