-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizon: Integration tests #1109
base: horizon
Are you sure you want to change the base?
Conversation
Horizon: Integration tests
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
c867b19
to
85b87a2
Compare
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
97bdc54
to
fb7c116
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this is gonna suck but I think we need to rebase the PR on top of tmigone/horizon-post-oz-audit2
. I introduced several changes to the tooling there including changing how this file is structured. I don't mind doing the rebase after you are done addressing the other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, what's most painful is the change in tests folder structure but I can do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it once we have this PR finalized, it's fair since I created that other branch after you started this one.
packages/horizon/test/integration/during-transition-period/service-provider.test.ts
Show resolved
Hide resolved
packages/horizon/test/integration/during-transition-period/service-provider.test.ts
Show resolved
Hide resolved
packages/horizon/test/integration/during-transition-period/service-provider.test.ts
Outdated
Show resolved
Hide resolved
packages/horizon/test/integration/during-transition-period/service-provider.test.ts
Show resolved
Hide resolved
packages/horizon/test/integration/during-transition-period/service-provider.test.ts
Show resolved
Hide resolved
packages/horizon/test/integration/after-transition-period/service-provider.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also cover the flows in the explorer and indexer-agent as those will be the most common ones. Probably using multicall. I can submit a PR with those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding more notes to myself mostly, don't worry about this for this PR:
- Delegation parameter config multicall tx
packages/horizon/test/integration/during-transition-period/slasher.test.ts
Show resolved
Hide resolved
packages/horizon/test/integration/during-transition-period/permissionless.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomás Migone <[email protected]>
No description provided.