Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use solidity division instead of fixed point scaling (OZ L-04) #1136

Open
wants to merge 1 commit into
base: horizon-oz2/l05-provision-params
Choose a base branch
from

Conversation

tmigone
Copy link
Member

@tmigone tmigone commented Mar 27, 2025

Signed-off-by: Tomás Migone [email protected]

@tmigone tmigone force-pushed the horizon-oz2/l04-fixed-point-precision branch from c163ec4 to b52befb Compare March 27, 2025 16:33
@tmigone tmigone changed the title fix: only check conditions for param that is changing when changing provision params (OZ L-05) fix: use solidity division instead of fixed point scaling (OZ L-04) Mar 27, 2025
@tmigone tmigone requested review from Maikol and pcarranzav March 27, 2025 16:34
@tmigone tmigone added bug Something isn't working horizon solidity audit-fix and removed bug Something isn't working labels Mar 27, 2025
Copy link

openzeppelin-code bot commented Mar 27, 2025

fix: only check conditions for param that is changing when changing provision params (OZ L-05)

Generated at commit: b52befbeffed4a966e3b62cae2057681984f0a7a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
38
59
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants