Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❄️ Graph Horizon and Subgraph Service ❄️ #944

Open
wants to merge 513 commits into
base: main
Choose a base branch
from
Open

❄️ Graph Horizon and Subgraph Service ❄️ #944

wants to merge 513 commits into from

Conversation

pcarranzav
Copy link
Member

No description provided.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Feb 20, 2024 •
edited
Loading

❄️ Graph Horizon and Subgraph Service ❄️

Generated at commit: da95d8ba2686a91d258c04d1f451737ced989849

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
4
0
15
38
59
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone tmigone changed the title [WIP/Experimental] Horizon draft changes [WIP/Experimental] BREAKING CHANGE: Horizon draft changes Feb 20, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Feb 21, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.55%. Comparing base (03d8d2a) to head (da95d8b).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...ges/contracts/contracts/rewards/RewardsManager.sol 76.00% 6 Missing ⚠️
packages/contracts/contracts/staking/Staking.sol 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   92.83%   92.55%   -0.29%     
==========================================
  Files          47       47              
  Lines        2415     2430      +15     
  Branches      438      438              
==========================================
+ Hits         2242     2249       +7     
- Misses        173      181       +8
Flag Coverage Δ
unittests 92.55% <84.31%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tmigone tmigone force-pushed the horizon branch 2 times, most recently from 76aa677 to 33b5790 Compare March 14, 2024 18:40
@socket-security Socket Security
Copy link

socket-security bot commented Mar 14, 2024 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@tmigone tmigone force-pushed the horizon branch 4 times, most recently from 1b27dfa to cae2490 Compare March 21, 2024 20:37
@tmigone tmigone changed the title [WIP/Experimental] BREAKING CHANGE: Horizon draft changes [WIP] Horizon draft changes Apr 12, 2024
@tmigone tmigone changed the title [WIP] Horizon draft changes [WIP] Horizon changes Apr 12, 2024
@tmigone tmigone changed the title [WIP] Horizon changes [WIP] Graph Horizon May 17, 2024
pcarranzav
pcarranzav commented Jun 6, 2024
View reviewed changes
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for now - still reviewing

pcarranzav
pcarranzav commented Jun 6, 2024
View reviewed changes
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, still reviewing...

pcarranzav
pcarranzav commented Jun 6, 2024
View reviewed changes
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moar

pcarranzav
pcarranzav commented Jun 7, 2024
View reviewed changes
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments - finished going through the main Solidity code

@tmigone tmigone marked this pull request as ready for review June 7, 2024 23:56
@tmigone tmigone changed the title [WIP] Graph Horizon Graph Horizon and Subgraph Service Jun 7, 2024
@tmigone tmigone changed the title Graph Horizon and Subgraph Service ❄️ Graph Horizon and Subgraph Service ❄️ Jun 8, 2024
@tmigone tmigone changed the title ❄️ Graph Horizon and Subgraph Service ❄️ ☀️ Graph Horizon and Subgraph Service ☀️ Sep 6, 2024
MoonBoi9001 and others added 4 commits October 1, 2024 13:57
@MoonBoi9001
fix: set drawDispute visability external.
32b3965
@MoonBoi9001
Merge pull request #1028 from graphprotocol/fix_oz_n-03
157216a 
fix: add security contact to various contract NatSpecs (OZ N-03)
@MoonBoi9001
fix: emit both amount authorized and total authorized
96b5c3c 
commit to now emit both the amount for which the collector was authorized and also the total amount for which they are now authorized
@MoonBoi9001
fix: set all ProvisionManager constants internal.
a598eca
matiasedgeandnode and others added 8 commits February 20, 2025 19:13
@tmigone tmigone changed the title ☀️ Graph Horizon and Subgraph Service ☀️ ❄️ Graph Horizon and Subgraph Service ❄️ Feb 21, 2025
tmigone added 20 commits February 24, 2025 17:50
@tmigone
fix: a few fixes
0b7730a 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
Merge pull request #1118 from graphprotocol/tmigone/horizon-last-minu…
26d5caa 
…te-fixes
@tmigone
chore: change some events for easier indexing
7187543 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
fix: ensure subgraph service contracts are owned by governor
830f7e8 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
Merge pull request #1119 from graphprotocol/tmigone/more-subgraph-cha…
7bac074 
…nges
@tmigone
fix: avoid boolean literals as conditionals
5a4a550 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: natspec and other documentation changes
28c5bda 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: natspec documentation changes on subgraph service contracts
6435f64 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: dont run natspec smells on lint
adf520e 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: use calldata instead of memory
56e044a 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: remove duplicated imports
2e8d285 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: no todo comments
fc83f8f 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: dont use named returns
72066de 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: add security contact to the contracts
4f60b0c 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: better getter name in dispute manager
77ab0c7 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: remove named returns
5557c5e 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: use custom errors
99f215c 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: clarify casting safety
9e8004e 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
chore: remove unused modifier
36efdac 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
Merge pull request #1123 from graphprotocol/tmigone/horizon-pre-audit…
da95d8b 
…-assesment

fix: pre-audit assessment fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigone tmigone tmigone left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
horizon protocol change solidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pcarranzav @tmigone @MoonBoi9001 @Maikol @matiasedgeandnode