Open
Conversation
Contributor
Summary of ChangesHello @mskorokhodov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the GraphQL Laboratory by extracting its core functionality into a dedicated, reusable library. This change improves code organization, enhances UI theming with semantic CSS variables, and introduces Shadow DOM encapsulation for better component isolation. It also includes updates to the Monaco Editor's theming and adds a new plugin for managing target-specific environment variables. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring that extracts the 'laboratory' feature into its own reusable package, @hive/laboratory. This includes moving all related components, hooks, and utilities. A new design system based on shadcn/ui and Tailwind CSS has been adopted, resulting in widespread styling changes. The new package is also made embeddable by using a Shadow Root to isolate styles. Overall, this is a great enhancement for modularity and reusability. I've found a few issues related to configuration, dependencies, and theming that should be addressed.
Comment on lines
+15
to
+19
| "components": "@/labaratory/components", | ||
| "utils": "@/labaratory/lib/utils", | ||
| "ui": "@/labaratory/components/ui", | ||
| "lib": "@/labaratory/lib", | ||
| "hooks": "@/labaratory/hooks" |
Contributor
There was a problem hiding this comment.
There's a typo in the path aliases. "labaratory" should be "laboratory". This will likely cause issues with path resolution.
Suggested change
| "components": "@/labaratory/components", | |
| "utils": "@/labaratory/lib/utils", | |
| "ui": "@/labaratory/components/ui", | |
| "lib": "@/labaratory/lib", | |
| "hooks": "@/labaratory/hooks" | |
| "components": "@/laboratory/components", | |
| "utils": "@/laboratory/lib/utils", | |
| "ui": "@/laboratory/components/ui", | |
| "lib": "@/laboratory/lib", | |
| "hooks": "@/laboratory/hooks" |
Comment on lines
+26
to
+36
| "peerDependencies": { | ||
| "@tanstack/react-form": "^1.23.8", | ||
| "date-fns": "^4.1.0", | ||
| "graphql-ws": "^6.0.6", | ||
| "lucide-react": "^0.548.0", | ||
| "lz-string": "^1.5.0", | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", | ||
| "tslib": "^2.8.1", | ||
| "zod": "^4.1.12" | ||
| }, |
Contributor
There was a problem hiding this comment.
There are version mismatches between peerDependencies and devDependencies for @tanstack/react-form and zod. While this might be intentional, it's generally better to keep these versions aligned to prevent potential compatibility issues for consumers of this library.
- @tanstack/react-form:
^1.23.8inpeerDependenciesvs^1.27.7indevDependencies. - zod:
^4.1.12inpeerDependenciesvs^4.3.6indevDependencies.
Please consider aligning these versions or ensuring that the specified ranges are compatible and intended.
Comment on lines
99
to
105
| const PreflightPromptModal = (props: { | ||
| open: boolean; | ||
| onOpenChange: (open: boolean) => void; | ||
| title?: string; | ||
| description?: string; | ||
| placeholder?: string; | ||
| placeholder: string; | ||
| defaultValue?: string; | ||
| onSubmit?: (value: string | null) => void; | ||
| }) => { |
Contributor
There was a problem hiding this comment.
The PreflightPromptModal component's props have been simplified, removing title and description. This reduces its flexibility as it can no longer show contextual information to the user when prompting for a value. This might be an oversight during refactoring. If this was not intentional, please consider re-adding these props to improve the user experience.
Comment on lines
10
to
14
| const Toaster = ({ ...props }: ToasterProps) => { | ||
| const { theme } = useTheme(); | ||
|
|
||
| return ( | ||
| <Sonner | ||
| theme={theme as ToasterProps['theme']} | ||
| theme="dark" | ||
| className="group" |
Contributor
There was a problem hiding this comment.
The Toaster component has a hardcoded theme="dark". The parent Laboratory component receives a theme prop that should be passed down to the Toaster to allow for dynamic theming (light/dark modes).
Suggested change
| const Toaster = ({ ...props }: ToasterProps) => { | |
| const { theme } = useTheme(); | |
| return ( | |
| <Sonner | |
| theme={theme as ToasterProps['theme']} | |
| theme="dark" | |
| className="group" | |
| const Toaster = ({ theme = 'dark', ...props }: ToasterProps & { theme?: string }) => { | |
| return ( | |
| <Sonner | |
| theme={theme as ToasterProps['theme']} | |
| className="group" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Description
Checklist