Combining @requires with @override doesnt work in apollo router composition #232
Conversation
…o in which you want to override a field annotated with @requires
Summary of ChangesHello @rickbijkerk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new test case to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…o in which you want to override a field annotated with @requires
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new test case to verify that Apollo Router composition works correctly when a field is annotated with both @requires and @override. The test setup is good, but there's a large block of commented-out code that should be removed to improve readability and maintainability.
| let result = composeServices([ | ||
| { | ||
| name: "a", | ||
| typeDefs: parse(/* GraphQL */ ` | ||
| extend schema | ||
| @link(url: "https://specs.apollo.dev/federation/v2.3" | ||
| import: ["@key"] | ||
| ) | ||
| type Query { | ||
| product(id:ID!): Product | ||
| } | ||
| type Product @key(fields: "id"){ | ||
| id: ID! | ||
| title: String! | ||
| description: String! | ||
| } | ||
| `), | ||
| }, | ||
| { | ||
| name: "b", | ||
| typeDefs: parse(/* GraphQL */ ` | ||
| extend schema | ||
| @link(url: "https://specs.apollo.dev/federation/v2.3" | ||
| import: ["@key", "@external", "@requires"] | ||
| ) | ||
| type Product @key(fields: "id"){ | ||
| id: ID! | ||
| description: String! @external | ||
| calculatedField: String! @requires(fields: "description") | ||
| } | ||
| `), | ||
| }, | ||
| { | ||
| name: "c", | ||
| typeDefs: parse(/* GraphQL */ ` | ||
| extend schema | ||
| @link(url: "https://specs.apollo.dev/federation/v2.3" | ||
| import: ["@key", "@override", "@requires", "@external"] | ||
| ) | ||
| type Product @key(fields: "id"){ | ||
| id: ID! | ||
| description: String! @external | ||
| calculatedField: String! @requires(fields: "description") @override(from: "b") | ||
| } | ||
| `), | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
This large block of commented-out code should be removed. It seems to be from a previous iteration of the test and is no longer needed, making the test harder to read.
1 participant
create failing test for the apollo router composition for the scenario in which you want to override a field annotated with @requires