Django v4, python 3.10 support for graphene-django v3 #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace calls to deprecated methods Fix test config & Replace additional methods removed in django 4.0 Update tox for official Django 4 release
This is being removed in django 4.1
|
Ah, good catch.
…On Thu, Dec 9, 2021, 3:23 PM Alexander ***@***.***> wrote:
the force_text to force_str patches are missing
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1281 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJYZP24HP7SBOW35VGKBVTUQEM4FANCNFSM5JVE6FLQ>
.
|
ulgens
previously requested changes
Dec 11, 2021
sry, it was a false alarm. This is why I removed my comment. The str_text patch is already included in master |
The DEFAULT_GRAPHQL_URL had to change because it doesn't take into account the APPEND_SLASH setting from within Django.
keithhackbarth
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
This comment looks solid to me. All of @ulgens feedback appears to be addressed. I don't see any additional issues. Great work @tim-schilling
|
@jkimbo can we get a beta 3.0.0b8 of this? this has the fixes I require for Python 3.10 usage |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This squashes and ports #1275, then fixes a few small issues for django main and python 3.10