Skip to content

Apply the visibility of the struct under derive to the generated module #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomhoule opened this issue Aug 6, 2018 · 4 comments
Closed

Apply the visibility of the struct under derive to the generated module #77

tomhoule opened this issue Aug 6, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@tomhoule
Copy link
Member

tomhoule commented Aug 6, 2018

E.g. if the struct is private, so should be the module, if it's public, same thing, etc.

syn::DeriveInput exposes it quite conveniently
@tomhoule tomhoule added the good first issue Good for newcomers label Aug 6, 2018
@davideGiovannini
Copy link

Hi @tomhoule, I would like to work on this

@tomhoule
Copy link
Member Author

tomhoule commented Oct 2, 2018

Great :) I'm at work now but I'll try to add more details later.

@tomhoule
Copy link
Member Author

tomhoule commented Oct 6, 2018

We need to:

  • Add the visibility of the module (crate, pub or private) to the DeriveOptions struct
  • Add this accordingly to the module in graphql-client-codegen

@h-michael h-michael mentioned this issue Oct 21, 2018
Merged
@tomhoule
Copy link
Member Author

tomhoule commented Nov 4, 2018

Fixed by #177 (thanks @h-michael !)

@tomhoule tomhoule closed this as completed Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomhoule @davideGiovannini