Let struct visibility to be same as module #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-michael
commented
Oct 21, 2018
graphql_client_cli/src/generate.rs
Outdated
| let module_visibility = match module_visibility { | ||
| Some("pub") => syn::VisPublic { pub_token: <Token![pub]>::default() }.into(), | ||
| Some("private") => syn::Visibility::Inherited {}, | ||
| _ => syn::VisPublic { pub_token: <Token![pub]>::default() }.into(), |
Member
Author
There was a problem hiding this comment.
Restricted(VisRestricted) needs complex variables.
So I implement pub and private at first for cli.
tomhoule
approved these changes
Oct 29, 2018
Member
tomhoule
left a comment
tomhoule
left a comment
There was a problem hiding this comment.
Looks good, thanks for implementing this!
Member
|
We just need a rebase and this will be merged. |
Member
Author
|
@tomhoule I've rebased it! |
Member
Author
|
Nightly build is failed, because of hyperium/hyper#1688. |
Member
|
Sorry for the delay :/ I'll merge anyway. |
Member
Author
|
@tomhoule |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature #77