Skip to content

Initial implementation of Subscription Docs #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 17, 2020

Conversation

engylemure
Copy link
Contributor

@engylemure engylemure commented Apr 9, 2020

Adds a advanced topic for Subscriptions in the book and a small example for it without the usage of a web integration. This PR fixes #588.

PR Checklist

Before submitting a PR, you should follow these steps to prevent redundant churn or CI failures:

  • Ensure proper formatting
  • Run all tests
  • Update the CHANGELOG

@LegNeato
Copy link
Member

These look awesome! @nWacky any interest in making sure it matches what you were thinking?

Copy link
Contributor

@nWacky nWacky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. Thank you so much for adding documentation on subscriptions, that looks great.

I'd dive a bit deeper in some topics to help to familiarize people with subscriptions, but the documentation is good even without that

@engylemure
Copy link
Contributor Author

@nWacky I have added these requested changes into the documentation, thanks for the review.

Copy link
Member

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some small edits. Thank you so much! We can clean up the rest / fix the links after it lands.

@LegNeato LegNeato merged commit 7e87247 into graphql-rust:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document subscriptions in the book
3 participants