Skip to content

Commit

Permalink
Use ExactKey for WorkloadIdentityParser to avoid parsing WorkloadIden…
Browse files Browse the repository at this point in the history
…tityX509Revocations (#52375)

* Use exactkey for WorkloadIdentityParser to avoid parsing
WorkloadIdentityX509Revocations

* Add TestWorkloadIdentityParser

* t.Parallel()
  • Loading branch information
strideynet authored Feb 21, 2025
1 parent 8f25fb6 commit f7045ab
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/services/local/workload_identity.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (b *WorkloadIdentityService) UpdateWorkloadIdentity(

func newWorkloadIdentityParser() *workloadIdentityParser {
return &workloadIdentityParser{
baseParser: newBaseParser(backend.NewKey(workloadIdentityPrefix)),
baseParser: newBaseParser(backend.ExactKey(workloadIdentityPrefix)),
}
}

Expand Down
39 changes: 39 additions & 0 deletions lib/services/local/workload_identity_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -353,3 +353,42 @@ func TestWorkloadIdentityService_UpdateWorkloadIdentity(t *testing.T) {
require.Error(t, err)
})
}

func TestWorkloadIdentityParser(t *testing.T) {
t.Parallel()
parser := newWorkloadIdentityParser()
t.Run("delete", func(t *testing.T) {
event := backend.Event{
Type: types.OpDelete,
Item: backend.Item{
Key: backend.NewKey("workload_identity", "example"),
},
}
require.True(t, parser.match(event.Item.Key))
resource, err := parser.parse(event)
require.NoError(t, err)
require.Equal(t, "example", resource.GetMetadata().Name)
})
t.Run("put", func(t *testing.T) {
event := backend.Event{
Type: types.OpPut,
Item: backend.Item{
Key: backend.NewKey("workload_identity", "example"),
Value: []byte(`{"kind":"workload_identity","version":"v1","metadata":{"name":"example"},"spec":{"spiffe":{"id":"/test"}}}`),
},
}
require.True(t, parser.match(event.Item.Key))
resource, err := parser.parse(event)
require.NoError(t, err)
require.Equal(t, "example", resource.GetMetadata().Name)
})
t.Run("does not match workload identity x509 revocation", func(t *testing.T) {
event := backend.Event{
Type: types.OpPut,
Item: backend.Item{
Key: backend.NewKey("workload_identity_x509_revocation", "example"),
},
}
require.False(t, parser.match(event.Item.Key))
})
}

0 comments on commit f7045ab

Please sign in to comment.