GitHub proxy: download GitHub server keys #50891
Conversation
greedy52
added
the
no-changelog
lib/srv/git/github.go
Outdated
| } | ||
|
|
||
| func (c *githubMetadataHTTPClient) fetchFingerprints() ([]string, string, error) { | ||
| resp, err := http.Get(c.api) |
There was a problem hiding this comment.
Why not use https://pkg.go.dev/github.com/google/go-github/v68/github#MetaService.Get instead? This is something that we likely only need to refresh at most every 24 hours or so.
There was a problem hiding this comment.
it's a pretty simple get call so i would prefer not to import another package. i also like the idea doing If-None-Match.
There was a problem hiding this comment.
I think I'd rather use pre-existing package to lower the maintenance costs, but it is true an extra dependency of this size is not trivial.
greedy52
changed the title
greedy52
force-pushed
the
STeve/48762_verify_github
branch
from
4a2bedb to
91a7bfd
Compare
greedy52
force-pushed
the
STeve/48762_verify_github
branch
2 times, most recently
from
e6f0ee3 to
7492d59
Compare
greedy52
force-pushed
the
STeve/48762_verify_github
branch
from
7492d59 to
c794c2f
Compare
greedy52
added
backport/branch/v17
github-integration
| return trace.Wrap(err) | ||
| } | ||
|
|
||
| // Start background downloads only when git_servers are found. |
There was a problem hiding this comment.
Are you sure we can't do the first fetch synchronously when needed instead of setting up a single-use watcher?
There was a problem hiding this comment.
as discussed above #50891 (comment), trying to avoid blocking on the first call. also we could retry upon failures this way.
i am happy to revert it to a lazy fetch on first call if we don't think the implementation is worth it.
There was a problem hiding this comment.
I think the async fetch is preferable. There is value in having the overall service up and running as quickly as possible.
public-teleport-github-review-bot
bot
removed the request for review
from gabrielcorado
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
* GitHub proxy: download GitHub server keys * review comments
* GitHub proxy: download GitHub server keys (#50891) * GitHub proxy: download GitHub server keys * review comments * remove empty line from bad merge
* GitHub proxy: download GitHub server keys * review comments
Related: