UserTasks: add title per issue type #52435
Open
+54
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the API to return the issue type title.
marcoandredinis
added
no-changelog
hugoShaka
approved these changes
Feb 24, 2025
Comment on lines
+42
to
+48
| title := documentParts[0] | ||
| if !strings.HasPrefix(title, "# ") { | ||
| return "", "" | ||
| } | ||
| title = title[2:] | ||
|
|
||
| description := strings.TrimSpace(documentParts[1]) |
There was a problem hiding this comment.
If the title does not start with an "#", is it better to return nothing, or an empty title and shove the whole bs string into the description?
I'm worried that someone will make a typo/forget the # and this would lead to obscure user tasks.
There was a problem hiding this comment.
We have a test that iterates over all IssueTypes and ensures none of them returns an empty string for both title and description.
That should be enough to prevent such scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the API to return the issue type title.