Change man made gray and text color, make text-dy uniform

[jeisenbe]

Fixes #3510
Related to #3512

Changes proposed in this pull request:

• Change the text color of man-made feature's name labels to man-made-icon gray darkened by 15%
• Make text-dy 10 for all of these man-made features
• Remove redundant name label code for wastewater and water plants
• Fix formating of natural_cave_entrance text-dy

Features affected
man_made = lighthouse, windmill, hunting_stand, bunker (currently gray)
historic = wayside_shrine (currently gray)
man_made = tower, mast, communications_tower, water_tower, chimney
power = generator with generator:sourece=wind - if this is merged (currently black)

Not affected: Religious items with black icon and text
man_made = cross
historic = wayside cross

Rational
All man_made features with icons in man-made-icon color (currently #555, dark gray) should have a name label in a matching color.

Currently, some man_made features have black text for the name label, others use man-made-icon gray. The text appears to be lighter than the corresponding icon when man-made-icon is used, but darker than the icon when black is used.

I would suggest darkening the man-made-icon color 10% or 15%

Also, the text-dy for lighthouses is currently excessive. I would also like to make the text-dy the same for all of these icons, which are all 14 x 14 pixels. As little as 8 is possible, but 10 looks best with extra-tall characters, as found in some languages.

Test rendering with links to the example places:

Test area 1:
Current rendering, z17

Man-made-icon 15% darker (except wayside cross)

Test area 2:
Current

15% Darkened

Samphire tower:
https://www.openstreetmap.org/?mlat=51.1056&mlon=1.275&zoom=17
Current

15%

WRC and WKYS towers in Washington, DC
Current black

15%

WDCU in Washington, DC
Current black

15%

Diamond Head Lighthouse, Hawaii
https://www.openstreetmap.org/?mlat=21.256944&mlon=-157.809444&zoom=17
man-made-gray (current rendering):

15% darker

Test of text-dy: 10 with tall characters

[Tomasz-W]

@jeisenbe You firstly opened #3500, and then made this PR. But if you change man-made colour later, new darkened label also become lighter (maybe worse?). I totally don't get this order.
Please finish #3500 first, and then we will match label colour to lighter man-made shade.

[jeisenbe]

It appears we don't need to worry about tall characters; the text dy function does move the text down based on the top of the text characters.

[jeisenbe]

You firstly opened #3500, and then made this PR. But if you change man-made colour later, new darkened label also become lighter (maybe worse?).

I was under the impression that #3500 was rejected.

[jeisenbe]

It looks like there may be enough support for changing man-made-icon color from the current #555 (same as #555555) dark gray to #666666, slightly lighter dark gray.

I believe darken 15% may still work well for the name labels, because the goal is to have the text look similar to the icon, but I will also show some tests with darken 20% and the new lighter icon color:

Test area 1,
Current (555 icon, text black or man-made icon)

Icon color (555) darkened 15% - this was the original PR suggestion

666666 darkened 15% - slightly lighter icon color and text color

666666 darkened 20% - slightly lighter icon color, text color darkened another 5%

Test area 2
Current (555 icon, text black or man-made-icon)

Icon color 555555, text darkened 15%

Icon color 666666, text darkened 15%

Icon color 666666, text darkened 20%

Tower on construction area in Wamena
https://www.openstreetmap.org/#map=17/-4.09819/138.94287
Current

Icon 555, darken text 15%

Icon 666666, darken text 15%

Icon 666666, darken text 20%

Washington DC WOOK Radio tower
https://www.openstreetmap.org/#map=17/38.93970/-77.07902
Current

555 darken 15%

666666 darken 15%

666666 darken 20%

WKYS Radio Tower
https://www.openstreetmap.org/#map=17/38.93970/-77.07902
Current

555 darken 15%

666666 darken 15%

666666 darken 20%

Crane Milano

[jeisenbe]

Milan train station:
Worse-case scenario with gray bridge area and dark gray mainline rail tracks
Crane icon 555

Crane icon 66666

I believe changing man-made-icon color to #666666 will work well with darken 20%; changes pushed

[Tomasz-W]

@jeisenbe Can you put few examples with text darken 5% and 10% to compare? (e.g. gastronomy-orange key has only 5% darken label)

[Adamant36]

I like 666666 darken 15% and 666666 darken 20%. I think 20% is the sweet spot, but it looks a little to light in residential areas. So, maybe 15% would be better due to that. Id like to see @Tomasz-W's suggestion also though.

[jeisenbe]

20% should look darker than 15% with the same icon color. But note that 555 is darker than 666666, so 555 darked 15% makes a similar text color, compared to 666666 darkened 20%

…

On Sat, Nov 17, 2018 at 3:17 AM Adamant36 ***@***.***> wrote: I like 666666 darken 15% and 666666 darken 20%. I think 20% is the sweet spot, but it looks a little to light in residential areas. So, maybe 15% would be better due to that. Id like to see @Tomasz-W <https://github.com/Tomasz-W>'s suggestion also though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3516 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshE9O6ckHcx_GNWEYYjTR9yP0pWlmks5uvwE0gaJpZM4Yk-Q8> .

[jeisenbe]

Text at 5% and 10% darker than new man-made-icon gray (#666666), as requested.

I believe 15% makes the text look best with the icon. 5% appears to be lighter than the icon, and 20% appears to be darker.

Test 1
5%

10%

15%

20%

Test 2
5%

10%

15%

20%

Mew Island Light icon #666666
5%

10%

15%

20%

Black Mountain Mast
5%

10%

15%

20%

[jeisenbe]

Does anyone else have comments about the color of the text?
@Tomasz-W - do you agree with darken 15%?

[Tomasz-W]

@jeisenbe Yes

[kocio-pl]

Sorry for being late to the party... I like the changes, though I think 20% is good enough for readability, 15% is still a bit too light for me.

[jeisenbe]

Ok. The current commit uses 20%, so it should be ready to merge.

…

On Tue, Nov 27, 2018 at 12:38 PM kocio-pl ***@***.***> wrote: Sorry for being late to the party... I like the changes, though I think 20% is good enough for readability, 15% is still a bit too light for me. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3516 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshJin-BnUhM0gmbAEgufCwVIIYbksks5uzLO1gaJpZM4Yk-Q8> .

[kocio-pl]

Frankly, this is so subtle change, that I just checked that nothing is broken, but I was not able to tell what has really changed.

Since testing multiple fixes is time consuming and error prone, I'd suggest (this is really just my personal suggestion, not a hidden warning 😄) to not focus too much on such fixes, because I will need a lot of time to focus to not let some fatal bug slip in. This is kind of code I will put on the bottom of my merge queue to keep my sanity and have more useful changes active.