Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Trim the unexpected rows query #10923

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

wookasz
Copy link
Contributor

@wookasz wookasz commented Feb 11, 2025

Allow trailing whitespace and ; in the unexpected rows query.

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 29da69f
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67aa9da646289f00080cef2e

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (5c60408) to head (29da69f).

✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (5c60408) and HEAD (29da69f). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (5c60408) HEAD (29da69f)
3.9 clickhouse 1 0
3.9 big 1 0
3.12 big 1 0
3.12 aws_deps 1 0
3.9 aws_deps 1 0
3.9 filesystem 1 0
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.9 spark_connect 1 0
3.12 spark_connect 1 0
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 1 0
3.12 filesystem 1 0
3.9 mysql 1 0
3.12 mysql 1 0
3.9 mssql 1 0
docs-spark 1 0
3.12 mssql 1 0
3.9 postgresql 1 0
3.12 postgresql 1 0
3.9 trino 1 0
3.12 trino 1 0
docs-basic 1 0
3.9 spark 1 0
cloud 1 0
3.12 spark 1 0
3.9 bigquery 1 0
3.12 bigquery 1 0
docs-creds-needed 1 0
3.9 snowflake 1 0
3.12 snowflake 1 0
3.9 databricks 1 0
3.12 databricks 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #10923       +/-   ##
============================================
- Coverage    80.77%   70.14%   -10.64%     
============================================
  Files          465      463        -2     
  Lines        40620    40618        -2     
============================================
- Hits         32812    28490     -4322     
- Misses        7808    12128     +4320     
Flag Coverage Δ
3.10 70.13% <100.00%> (+0.04%) ⬆️
3.11 70.13% <100.00%> (+0.04%) ⬆️
3.12 70.13% <100.00%> (+0.03%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.12 aws_deps ?
3.12 big ?
3.12 bigquery ?
3.12 databricks ?
3.12 filesystem ?
3.12 mssql ?
3.12 mysql ?
3.12 postgresql ?
3.12 snowflake ?
3.12 spark ?
3.12 spark_connect ?
3.12 trino ?
3.9 70.15% <100.00%> (+0.04%) ⬆️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 bigquery ?
3.9 clickhouse ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 spark_connect ?
3.9 trino ?
cloud ?
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants