v1.3.5#324
Conversation
|
|
I've tested the addition of actionlint and the changes to the first time setup workflow in my own fork, and they work as expected. Actionlint's integration with shellcheck caught some things... not major things (should be extremely rare edge cases) but I incorporated the suggestions. |
d33bs
left a comment
d33bs
left a comment
There was a problem hiding this comment.
Nice! I looked this through and everything seemed on point to me.
Double checking: I might have missed the changes for #320 - were those included? I didn't see any changes to _includes/tags.html, if that's where the changes were to be applied. I also might be misunderstanding where those changes need to take place.
|
You're right, I don't know how that change got lost, I think I was originally doing it in #323 and forgot to transfer it here, thanks. |
Closes greenelab#321 Closes greenelab#320 Closes greenelab#322 Supersedes greenelab#323 Co-authored by @d33bs FOR THE TEMPLATE MAINTAINER(S) New template version checklist: - [x] I have updated CITATION and CHANGELOG as appropriate. - [x] I have updated lab-website-template-docs as appropriate. - [x] I have checked the testbed as appropriate.
2 participants
Closes #321
Closes #320
Closes #322
Supersedes #323
Co-authored by @d33bs
FOR THE TEMPLATE MAINTAINER(S)
New template version checklist: