Upgrade react-pdf from v8 to v9 #894
Draft
+189
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
gigxz
commented
Dec 30, 2024
gigxz
commented
Dec 30, 2024
| @@ -1,14 +1,11 @@ | |||
| import { DialogProps, Paper, Stack } from '@mui/material'; | |||
| import pdfWorker from 'pdfjs-dist/build/pdf.worker.js?url'; | |||
There was a problem hiding this comment.
it makes more sense for this to live in FilePreview since that component is actually rendering the pdf previews
|
Tested on QA, I'm getting "Failed to load PDF file." when viewing PDF there. Marking PR as draft for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade
react-pdffrom 8=>9. Reference documentation https://github.com/wojtekmaj/react-pdf/wiki/Upgrade-guide-from-version-8.x-to-9.xWe had already determined that CVE-2024-4367 was not affecting us, but this upgrade upgrades
pdfjs-distto the patched version, so we get rid of the audit alert.How to test:
Type of change
Checklist before requesting review