Use CleanBaseMutation

greenriver · Feb 6, 2025 · 7f32663 · 7f32663
1 parent b1acea3
commit 7f32663
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 32 deletions.
diff --git a/drivers/hmis/app/graphql/mutations/split_household.rb b/drivers/hmis/app/graphql/mutations/split_household.rb
@@ -5,7 +5,7 @@
 ###
 
 module Mutations
-  class SplitHousehold < BaseMutation
+  class SplitHousehold < CleanBaseMutation
     argument :splitting_enrollment_inputs, [Types::HmisSchema::EnrollmentRelationshipInput], required: true
 
     field :new_household, Types::HmisSchema::Household, null: false

diff --git a/drivers/hmis/app/graphql/schema.graphql b/drivers/hmis/app/graphql/schema.graphql
@@ -6252,12 +6252,7 @@ type Mutation {
     """
     input: SaveAssessmentInput!
   ): SaveAssessmentPayload
-  splitHousehold(
-    """
-    Parameters for SplitHousehold
-    """
-    input: SplitHouseholdInput!
-  ): SplitHouseholdPayload
+  splitHousehold(splittingEnrollmentInputs: [EnrollmentRelationshipInput!]!): SplitHouseholdPayload
 
   """
   Create/Submit assessment, and create/update related HUD records
@@ -11185,25 +11180,10 @@ enum SexualOrientation {
   QUESTIONING_UNSURE
 }
 
-"""
-Autogenerated input type of SplitHousehold
-"""
-input SplitHouseholdInput {
-  """
-  A unique identifier for the client performing the mutation.
-  """
-  clientMutationId: String
-  splittingEnrollmentInputs: [EnrollmentRelationshipInput!]!
-}
-
 """
 Autogenerated return type of SplitHousehold.
 """
 type SplitHouseholdPayload {
-  """
-  A unique identifier for the client performing the mutation.
-  """
-  clientMutationId: String
   errors: [ValidationError!]!
   newHousehold: Household!
   remainingHousehold: Household!

diff --git a/drivers/hmis/spec/requests/hmis/split_household_spec.rb b/drivers/hmis/spec/requests/hmis/split_household_spec.rb
@@ -14,8 +14,8 @@
 
   let(:mutation) do
     <<~GRAPHQL
-      mutation SplitHousehold($input: SplitHouseholdInput!) {
-        splitHousehold(input: $input) {
+      mutation SplitHousehold($splittingEnrollmentInputs: [EnrollmentRelationshipInput!]!) {
+        splitHousehold(splittingEnrollmentInputs: $splittingEnrollmentInputs) {
           newHousehold {
             id
             householdSize
@@ -63,9 +63,7 @@ def perform_mutation(
     ]
   )
     input = {
-      input: {
-        splitting_enrollment_inputs: splitting_enrollment_inputs,
-      },
+      splitting_enrollment_inputs: splitting_enrollment_inputs,
     }
     response, result = post_graphql(input) { mutation }
 
@@ -113,7 +111,7 @@ def perform_mutation(
         },
       ],
     }
-    expect_access_denied post_graphql(input: input) { mutation }
+    expect_access_denied post_graphql(input) { mutation }
   end
 
   it 'fails when the given enrollment IDs are invalid' do
@@ -125,7 +123,7 @@ def perform_mutation(
         },
       ],
     }
-    expect_access_denied post_graphql(input: input) { mutation }
+    expect_access_denied post_graphql(input) { mutation }
   end
 
   context 'when the given enrollment IDs come from different households' do
@@ -144,7 +142,7 @@ def perform_mutation(
           },
         ],
       }
-      expect_gql_error post_graphql(input: input) { mutation }
+      expect_gql_error post_graphql(input) { mutation }
     end
   end
 
@@ -165,7 +163,7 @@ def perform_mutation(
         },
       ],
     }
-    expect_gql_error post_graphql(input: input) { mutation }, message: /Splitting all clients to a new household is invalid/
+    expect_gql_error post_graphql(input) { mutation }, message: /Splitting all clients to a new household is invalid/
   end
 
   it 'fails when the split would leave behind a headless household' do
@@ -177,6 +175,6 @@ def perform_mutation(
         },
       ],
     }
-    expect_gql_error post_graphql(input: input) { mutation }, message: /This operation would leave behind a household with no HoH, which is not allowed/
+    expect_gql_error post_graphql(input) { mutation }, message: /This operation would leave behind a household with no HoH, which is not allowed/
   end
 end