Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 Hud List generated JSON file updates #4302

Open
wants to merge 5 commits into
base: stable
Choose a base branch
from

Conversation

dtgreiner
Copy link
Contributor

Please squash merge this PR

Description

Initial run of the 2024 Hud List json generator from the machine readable excel file.

Type of change

  • Code clean-up / housekeeping

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (rubocop)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

Copy link
Contributor Author

@dtgreiner dtgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is just the base run of the generator without any additional cleanup. I believe the "Unknown" codes are related to the "VoucherTracking" and "HOPWAFinancialAssistance" lists.

@dtgreiner dtgreiner requested a review from eanders April 30, 2024 15:26
@eanders eanders requested a review from gigxz April 30, 2024 23:32
@eanders
Copy link
Contributor

eanders commented Apr 30, 2024

Thanks @dtgreiner !
@gigxz let's review this in the next few days (weeks?) and update as appropriate so we don't break anything for FY2024, but make sure we catch any bugs from the first-pass. Once it's good, I think we're all set to merge all the way down.

@gigxz
Copy link
Contributor

gigxz commented May 2, 2024

Sounds good! Can I push directly to this branch or should I comment suggestions?

@dtgreiner @eanders are you intentionally holding off on running rails code:generate_hud_lists (and rails driver:hmis:generate_graphql_enums and rails driver:hmis:dump_graphql_schema) on this branch?

That is what I'm doing locally so I know what to fix, so it might be easier to see the diff in git. But if you don't want to push that, I will just look locally and leave comments on the JSON file.

Edit: I'm working off another branch. The diff is huge because I pulled in release-115, but the file I'm looking at for comparisons is drivers/hmis/app/graphql/schema.graphql. Ideally this should not have any changes to the graphql schema except changes to the labels where it makes sense, or changes where something was actually missed (I found 2 -- proposed them here #4315 since they are actual bug fixes). It is going to take me a while to go through it.

So far I just made the bare minimum changes to get the schema generating again: e5f462b

},
{
"key": 151,
"description": "HOPWA Financial Assistance"
"description": "PATH referral"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect for 151

Base automatically changed from dg/machine_readable_hud_list-378-r114 to release-116 May 8, 2024 17:08
Base automatically changed from release-116 to stable May 24, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants