Added support for Mac OS X and Racket 7.0 #25
Conversation
|
Thank you for submitting this PR. I only just took a look at it, now. I like the idea of supporting macOS. I'm just hesitating while I digest and think about this.... |
| if [[ "$RACKET_MINIMAL" = "1" ]]; then | ||
| echo "Minimal Racket: Installing packages for raco test..." | ||
| ${RACKET_DIR}/bin/raco pkg install --auto --scope installation rackunit-lib compiler-lib | ||
| if [[ "$RACKET_MINIMAL" = "1" ]]; then |
There was a problem hiding this comment.
You have this nested under the non-Darwin else branch. But, should this be moved out to be done for Darwin, too?
I ask because it looks like you are including the minimal-racket scenario, up above. So, wouldn't you want this for minimal-Racket on Darwin, too? (Apologies if I'm misunderstanding.)
There was a problem hiding this comment.
I'm sorry to be slow to follow up and review this. Partly I've been super busy. But also, I feel like adding the macOS "dimension" means the conditionals and permutations is getting to be a slightly heavy cognitive load.
I don't mean to sound like I'm complaining -- I really appreciate you taking the time to do and submit this PR. Thanks for that!!
|
+1 for supporting OS X. |
3 participants
Hi,
I added support for Mac OS and Racket 7.0