Add JRE dependency to Java components #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR integrates a Java LPM (LocalStack Package Manager) package across the LocalStack codebase, removing the default system-wide JRE installation and making each component responsible for its required Java version.
- Removed system-wide JRE installation from Dockerfile, shifting responsibility to individual components
- Added Java dependencies to DynamoDB, EventRuler, OpenSearch, Elasticsearch, StepFunctions, and Kinesis Connector
- Specified different Java versions for components (e.g., Java 11 for OpenSearch, Java 8 for Elasticsearch)
- Updated environment variable setup and JVM initialization processes in affected components
- Modified package installers to include Java installation as part of their preparation steps
10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+469
to
+470
| elasticsearch_installer = elasticsearch_package.get_installer(self.version) | ||
| java_home = java_package.get_installer(elasticsearch_installer.java_version).get_java_home() |
There was a problem hiding this comment.
style: Consider using a constant for the default Java options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
localstack#11139 introduced a Java LPM package that can install and manage multiple LTS versions of JRE.
This PR integrates this package across the codebase.
Changes