Feature/Eventbridge v2: Add ECS target #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds support for ECS (Elastic Container Service) targets in EventBridge for LocalStack, enhancing the platform's compatibility with AWS services.
- Implemented
ECSTargetSenderclass inlocalstack/services/events/target.pyto handle ECS-specific event routing - Added input validation and parameter extraction for ECS targets, including network configuration, launch type, and capacity provider strategy
- Refactored EventBridge fixtures in
localstack/testing/pytest/fixtures.pyfor improved granularity and control in testing - Updated various test files to use the new
sqs_as_events_targetfixture, replacingcreate_sqs_events_target
10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+309
to
+310
| if ecs_parameters.get("CapacityProviderStrategy") and ecs_parameters.get("LaunchType"): | ||
| raise ValueError("only LaunchType or CapacityProviderStrategy can be provided") |
There was a problem hiding this comment.
logic: Check if both LaunchType and CapacityProviderStrategy are provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EventBridge can be used to invoke a ECS task, this PR adds this feature to LocalStack.
Changes
Testing
Since ECS is a pro feature, the aws validated test can be found in this companion branch: https://github.com/localstack/localstack-ext/pull/3369