Feature: Eventbridge v2: Add connection for api endpoint#15
Open
lizard-boy wants to merge 11 commits intomasterfrom
Open
Feature: Eventbridge v2: Add connection for api endpoint#15lizard-boy wants to merge 11 commits intomasterfrom
lizard-boy wants to merge 11 commits intomasterfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adds significant functionality and tests for EventBridge V2 connections, focusing on API endpoints. Here are the key changes:
- Introduced new tests for EventBridge connections, covering creation, listing, describing, updating, and deleting with various authentication types (BASIC, OAUTH_CLIENT_CREDENTIALS, API_KEY).
- Added a new fixture
events_create_connectionin conftest.py to simplify connection testing. - Implemented a helper function
events_connection_wait_for_deletedto ensure proper cleanup of connections during tests. - Reorganized and expanded test coverage for EventBridge targets, moving integration tests to a dedicated file (test_events_targets.py).
- Added a new test case for ignoring schedules in
put_eventsoperations, currently skipped for V2 provider.
13 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| len([e for e in events_after["events"] if "manually invoked" in e["message"]]) == 0 | ||
| ) | ||
|
|
||
| retry(check_invocation, sleep=5, retries=15) |
There was a problem hiding this comment.
style: Consider adjusting retry parameters if test is flaky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes