Fix for bug: CloudFormation tags on AWS::Serverless::Function do not deploy #11459 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses a bug where CloudFormation tags on AWS::Serverless::Function were not deploying correctly, improving tag handling for Lambda functions in LocalStack.
- Added tag validation in
localstack-core/localstack/services/lambda_/provider.py, including length limits and character restrictions - Implemented tag processing for AWS::Lambda::Function resources in
localstack-core/localstack/services/lambda_/resource_providers/aws_lambda_function.py - Ensured automatic addition of required CloudFormation-specific tags to Lambda functions
- Enhanced
createmethod in LambdaFunctionProvider class to apply tags from CloudFormation templates - Updated tests in
tests/aws/services/lambda_/test_lambda_api.pyto cover new tag-related functionalities
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| tags[tag_dict_key] = tag_dict_value | ||
|
|
||
| # the following mmust be added by default as specified here: | ||
| # https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-resource-tags.html |
There was a problem hiding this comment.
syntax: 'mmust' is misspelled, should be 'must'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This contains a fix for localstack#11459
Changes