Fix a race in Close method of SubscriptionClient (shurcooL#27)

grihabor · Jan 11, 2022 · 01a575e · 01a575e
1 parent 9eed82e
commit 01a575e
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/subscription.go b/subscription.go
@@ -557,14 +557,12 @@ func (sc *SubscriptionClient) Reset() error {
 func (sc *SubscriptionClient) Close() (err error) {
 	sc.setIsRunning(false)
 
-	sc.subscribersMu.Lock()
 	for id := range sc.subscriptions {
 		if err = sc.Unsubscribe(id); err != nil {
 			sc.cancel()
 			return err
 		}
 	}
-	sc.subscribersMu.Unlock()
 
 	if sc.conn != nil {
 		_ = sc.terminate()