Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallelization block fixed setup #122

Merged
merged 2 commits into from
Jan 30, 2025
Merged

parallelization block fixed setup #122

merged 2 commits into from
Jan 30, 2025

Conversation

lmseidler
Copy link
Member

  • setting the minimum number of required cores by the maximum of all settings

@marcelmbn
Copy link
Member

Could you add maybe two sentences on what was wrong before? And how it is fixed in this PR? Just to make sure that we don't create problems on other ends of the parallelization logic. :)

@marcelmbn
Copy link
Member

Other than that: Seems to work, great! 💯

@lmseidler
Copy link
Member Author

lmseidler commented Jan 30, 2025

Before the program checked for the minimum number of cores required to run by looking also at the minimum number of cores requested in the configuration, which is of course illogical. It should be the maximum number of cores requested, which led to the problem:

If refine requests 2 cores and postprocessing requests 4, the program will set up the blocks considering 2 cores as the minimum requirement, which possibly leads to postprocessing jobs not launching indefinitely due to being blocked by resource management (blocks only have 2 cores available).

@marcelmbn
Copy link
Member

Makes sense. Thanks for your contribution!

Signed-off-by: Marcel Müller <[email protected]>
@marcelmbn marcelmbn merged commit 3f1289e into main Jan 30, 2025
13 checks passed
@marcelmbn marcelmbn deleted the parallelization-setup branch January 30, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelization setup prevents mindlessgen from doing anything
2 participants