Support ghc 8.10 #129
Open
Support ghc 8.10 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
414owen
commented
Jan 12, 2022
| @@ -434,7 +434,7 @@ codeGenCase opVal alts bindingGen = do | |||
| (Alt DefaultPat _, _) -> True | |||
| _ -> False | |||
| (defaultAlts, normalAlts) = List.partition isDefault alts | |||
| when (length defaultAlts > 1) $ fail "multiple default patterns" | |||
There was a problem hiding this comment.
This was complaining that Identity didn't implement MonadFail.
I think that means it was calling error before this change anyway.
| @@ -244,7 +244,7 @@ library | |||
| optparse-applicative, | |||
| directory, | |||
| pretty-simple, | |||
| functor-infix, | |||
There was a problem hiding this comment.
I looked into getting functor-infix to increase its bounds, but the author is unresponsive, so I think it's best to switch libraries.
I prefer composition-extra's approach anyway. No TH necessary.
| @@ -260,7 +260,8 @@ library | |||
| deepseq, | |||
| binary, | |||
| unix, | |||
| libffi | |||
| libffi, | |||
| data-fix | |||
There was a problem hiding this comment.
I think recursion-schemes used to reexport Fix...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change:
Well I ran
nix-shell shell.nixover an hour ago and it still hasn't finished...With this change, all you need to run to get a working environment is
nix-shell -p ghc cabal llvmPackages_7.llvm pkg-config libffi, and your binary caches will work their magic.I had to make some changes to
llvm-hs, I'll try upstreaming them.Some end-to-end tests are failing because of missing
*.binaryfiles. Not sure what the deal is. I'll see if the CI has more luck.