Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout and spacing docs #4636

Draft
wants to merge 14 commits into
base: docs/global-tokens
Choose a base branch
from
Draft

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Dec 20, 2024

Deploy Preview

What does this PR do?

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

halocline and others added 6 commits December 17, 2024 13:23
* Resolved console error regarding defaultProps deprecation

* Moved Compare, ModeContext, and StyleInProgress to local components

* Moved Type components

* Moved Controls components

* Added tabs for sticker-sheet content

* Keep track of active tab index

* Moved Inputs components

* Moved Visualizations components

* Moved Layout components
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 857b301

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hpe-design-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants