Accept multiple SQLCipher libraries#1819
Merged
groue merged 2 commits intodevelopmentfrom Oct 12, 2025
Merged
Conversation
Owner
Author
Contributor
|
@groue This looks good to us as well. I believe we'll still need to adjust the order so that the we'll sync up our fork once this is merged in and base our PR off of it. |
… availability GRDBCIPHER is now just a marker for importing SQLCipher with CocoaPods. Also, enable all APIs that used to be disabled with SQLCipher, and skip tests that require a specific SQLite version.
35d6fbc to
c35095c
Compare
Owner
Author
|
The import section was refactored in #1826. This pull request has been rebased on top of it, and does no longer modify the imports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims at easing the job of #1708 and #1816, by checking the
SQLITE_HAS_CODECcompiler flag for enabling SQLCipher features.The
GRDBCIPHERcompiler flag is now only used for detecting the SQLCipher CocoaPods:@marcprux, @R4N, I'll merge if you both agree that this pull request is actually useful.