Skip to content

build: Resolve compiler warnings #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Resolve compiler warnings #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions proto_processing_lib/factory_helper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@

namespace proto_processing_lib {

// Factory Method to create UnknownFieldChecker.
static const proto_processing_lib::proto_scrubber::FieldCheckerInterface*
FactoryCreateUnknownFieldChecker() {
return proto_processing_lib::proto_scrubber::UnknownFieldChecker::
GetDefault();
}

// Factory Method to create UnknownFieldChecker.
static std::unique_ptr<proto_processing_lib::FieldMaskTreeInterface>
FactoryCreateFieldMaskTree(
Expand Down
6 changes: 3 additions & 3 deletions proto_processing_lib/proto_scrubber/field_mask_tree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class FieldMaskTree : public FieldMaskTreeInterface {
// Returns OK if all "paths" are legal, otherwise returns INVALID_ARGUMENT and
// the tree will be left in a broken state. Calling this method again on a
// broken FieldMaskTree will yield an error of FAILED_PRECONDITION.
absl::Status AddOrIntersectFieldPaths(const std::vector<std::string>& paths);
absl::Status AddOrIntersectFieldPaths(const std::vector<std::string>& paths) override;

// Checks if a field is on this tree. Returns "kInclude" if the field is on a
// leaf node of the tree, "kPartial" if it's on a non-leaf node and "kExclude"
Expand All @@ -96,10 +96,10 @@ class FieldMaskTree : public FieldMaskTreeInterface {
}

// Returns the status of the tree.
absl::Status status() { return status_; }
absl::Status status() override { return status_; }

// Returns root node of the tree.
const FieldMaskNode* root() const { return root_.get(); }
const FieldMaskNode* root() const override { return root_.get(); }

private:
// The root node of the FieldMask tree.
Expand Down