-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry: Refactor tracing and metrics separately #8063
base: master
Are you sure you want to change the base?
opentelemetry: Refactor tracing and metrics separately #8063
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8063 +/- ##
==========================================
+ Coverage 82.27% 82.41% +0.13%
==========================================
Files 386 387 +1
Lines 39038 39057 +19
==========================================
+ Hits 32120 32189 +69
+ Misses 5590 5549 -41
+ Partials 1328 1319 -9
|
69df069
to
71804b4
Compare
@janardhanvissa its not clear what is the intention of this refactor. The follow up from opentelemetry tracing API PR was to create separate interceptors for metrics and traces. Right now, single interceptor is handling both trace and metrics options. Once we have separate unary and stream interceptor each for tracing and metrics, we don't have to check for options disabled/enabled everytime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see this discussion https://github.com/grpc/grpc-go/pull/7852/files#r1909469701 and modify accordingly.
RELEASE NOTE: This release refines the separation of metrics and tracing logic.