Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry: Refactor tracing and metrics separately #8063

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

janardhanvissa
Copy link
Contributor

RELEASE NOTE: This release refines the separation of metrics and tracing logic.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (39f0e5a) to head (76e422a).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8063      +/-   ##
==========================================
+ Coverage   82.27%   82.41%   +0.13%     
==========================================
  Files         386      387       +1     
  Lines       39038    39057      +19     
==========================================
+ Hits        32120    32189      +69     
+ Misses       5590     5549      -41     
+ Partials     1328     1319       -9     
Files with missing lines Coverage Δ
stats/opentelemetry/client_metrics.go 90.14% <100.00%> (+0.74%) ⬆️

... and 35 files with indirect coverage changes

@janardhanvissa janardhanvissa force-pushed the refactor-tracing-metrics branch from 69df069 to 71804b4 Compare February 3, 2025 11:48
@purnesh42H
Copy link
Contributor

@janardhanvissa its not clear what is the intention of this refactor. The follow up from opentelemetry tracing API PR was to create separate interceptors for metrics and traces. Right now, single interceptor is handling both trace and metrics options. Once we have separate unary and stream interceptor each for tracing and metrics, we don't have to check for options disabled/enabled everytime.

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see this discussion https://github.com/grpc/grpc-go/pull/7852/files#r1909469701 and modify accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants