Update available to fix build for non-macOS Apple platforms #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
force-pushed
the
sb/add-missing-availabilty-guards
branch
from
54af59a to
32024f7
Compare
glbrntt
approved these changes
Dec 19, 2023
Tests/GRPCCoreTests/Test Utilities/RPCAsyncSequence+Utilities.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Si Beaumont <[email protected]>
glbrntt
pushed a commit
to glbrntt/grpc-swift
that referenced
this pull request
Feb 5, 2024
## Motivation The package currently doesn't build for non-macOS Apple platforms, e.g. iOS, because of missing `@available` annotations, mostly in tests. ## Modifications - Add missing `@available` annotations. - Use `#if os(macOS) || os(Linux)` in test utils that require `Foundation.Process`. Ideally we'd use `#if canImport(Foundation.Process)`, but the version of `swift-format` used by this project doesn't understand it. ## Result Code and tests can build for, and run on, other platforms, e.g. iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The package currently doesn't build for non-macOS Apple platforms, e.g. iOS, because of missing
@availableannotations, mostly in tests.Modifications
@availableannotations.#if os(macOS) || os(Linux)in test utils that requireFoundation.Process. Ideally we'd use#if canImport(Foundation.Process), but the version ofswift-formatused by this project doesn't understand it.Result
Code and tests can build for, and run on, other platforms, e.g. iOS.