Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bodyParts computed prop to StreamingClientResponse #2184

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Add bodyParts computed prop to StreamingClientResponse #2184

merged 5 commits into from
Jan 31, 2025

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Jan 28, 2025

This PR resolves #2183

@gjcairo gjcairo added the 🆕 semver/minor Adds new public API. label Jan 28, 2025
@gjcairo gjcairo requested a review from glbrntt January 28, 2025 22:21
@gjcairo gjcairo requested a review from glbrntt January 29, 2025 08:50
glbrntt
glbrntt requested changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo doc nits. A bit surprised the docs check didn't pick this up to be honest.

Sources/GRPCCore/Call/Client/ClientResponse.swift Outdated Show resolved Hide resolved
Sources/GRPCCore/Call/Client/ClientResponse.swift Outdated Show resolved Hide resolved
@gjcairo gjcairo requested a review from glbrntt January 29, 2025 14:24
glbrntt
glbrntt approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjcairo!

@glbrntt glbrntt added the do-not-merge This change shouldn't be merged. label Jan 29, 2025
@glbrntt glbrntt removed the do-not-merge This change shouldn't be merged. label Jan 31, 2025
@glbrntt glbrntt enabled auto-merge (squash) January 31, 2025 14:28
@glbrntt glbrntt merged commit 2b17298 into grpc:main Jan 31, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helper to get body parts from a streaming client response
2 participants
@gjcairo @glbrntt