Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build examples twice #2189

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Don't build examples twice #2189

merged 2 commits into from
Jan 31, 2025

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 31, 2025

Motivation:

The CI for examples builds them in the setup stage and the actual run stages. That's just a silly oversight.

Modifications:

  • Don't build them during set.

Result:

Examples don't build twice in CI

Motivation:

The CI for examples builds them in the setup stage and the actual run
stages. That's just a silly oversight.

Modifications:

- Don't build them during set.

Result:

Examples don't build twice in CI
@glbrntt glbrntt added the semver/none No version bump required. label Jan 31, 2025
@glbrntt glbrntt enabled auto-merge (squash) January 31, 2025 15:55
Copy link
Collaborator

@rnro rnro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easily done done

@glbrntt glbrntt merged commit c51d91b into grpc:main Jan 31, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants