Minor fix on exposed services

grycap · May 20, 2024 · 2d1a9bd · 2d1a9bd
1 parent 3d59fa4
commit 2d1a9bd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/pkg/handlers/delete.go b/pkg/handlers/delete.go
@@ -38,9 +38,6 @@ func MakeDeleteHandler(cfg *types.Config, back types.ServerlessBackend) gin.Hand
 		// First get the Service
 		service, _ := back.ReadService(c.Param("serviceName"))
 		authHeader := c.GetHeader("Authorization")
-		if service.Expose.APIPort != 0 {
-			// Delete exposed service
-		}
 
 		if len(strings.Split(authHeader, "Bearer")) > 1 {
 			uid, err := auth.GetUIDFromContext(c)
@@ -49,7 +46,7 @@ func MakeDeleteHandler(cfg *types.Config, back types.ServerlessBackend) gin.Hand
 			}
 
 			if service.Owner != uid {
-				c.String(http.StatusForbidden, "User %s doesn't have permision to get this service", uid)
+				c.String(http.StatusForbidden, "User %s doesn't have permision to delete this service", uid)
 				return
 			}
 		}

diff --git a/pkg/types/expose.go b/pkg/types/expose.go
@@ -534,8 +534,7 @@ func listIngress(kubeClientset kubernetes.Interface, cfg *Config) (*net.IngressL
 // Delete a kubernetes ingress
 func deleteIngress(name string, kubeClientset kubernetes.Interface, cfg *Config) error {
 	// if secret exist, delete
-	ingress := getIngressName(name)
-	err := kubeClientset.NetworkingV1().Ingresses(cfg.ServicesNamespace).Delete(context.TODO(), ingress, metav1.DeleteOptions{})
+	err := kubeClientset.NetworkingV1().Ingresses(cfg.ServicesNamespace).Delete(context.TODO(), name, metav1.DeleteOptions{})
 	if err != nil {
 		return err
 	}