Revert the MSVAVFLAGS_UNVERIFIED_SPN flag default #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default SSPI does not set this flag, and setting it causes servers with restrictive policy to fail authentication. Given no MS client sets this flag by default, neither should we until there is a clear need. We trust our calling applications to do the right thing here in any case just like SSPI trusts their own calling applications. Signed-off-by: Simo Sorce <[email protected]>
jborean93
approved these changes
Mar 15, 2022
|
Can confirm these changes allow gss-ntlmssp to work with a server that's set to verify the SPN from an NTLM exchange. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default SSPI does not set this flag, and setting it causes servers
with restrictive policy to fail authentication. Given no MS client sets
this flag by default, neither should we until there is a clear need.
We trust our calling applications to do the right thing here in any
case just like SSPI trusts their own calling applications.
Fixes #67