Skip to content

Revert the MSVAVFLAGS_UNVERIFIED_SPN flag default #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Revert the MSVAVFLAGS_UNVERIFIED_SPN flag default #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/gss_sec_ctx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,15 @@ uint32_t gssntlm_accept_sec_context(uint32_t *minor_status,
goto done;
}

av_flags = MSVAVFLAGS_UNVERIFIED_SPN;
/* TODO: allow client applications to set a context option to
* provide an av_flags default value so that flags like
* MSVAVFLAGS_UNVERIFIED_SPN can be set. By default SSPI does
* not set this flag, and setting it causes servers with restrictive
* policy to fail authentication. Given no MS client set this flag
* by default, neither should we until there is a clear need. We
* trust our calling applications to do the right thing here.
* av_flags = MSVAVFLAGS_UNVERIFIED_SPN;
*/

timestamp = ntlm_timestamp_now();

Expand Down
1 change: 0 additions & 1 deletion src/ntlm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,6 @@ int ntlm_process_target_info(struct ntlm_ctx *ctx, bool protect,
ret = ENOMEM;
goto done;
}
av_flags |= MSVAVFLAGS_UNVERIFIED_SPN;
}

ret = ntlm_encode_target_info(ctx,
Expand Down