Fix crash in acquiring credentials #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozencemetery
suggested changes
Sep 23, 2020
When a credential store is provided, but no name is provided, we end up crashing by dereferencing the name. Allow the request to proceed without a name, as it may be selected out of a credential file, but if none was found, return an error. Signed-off-by: Simo Sorce <[email protected]>
The code was incorrectly immediately erroring out if no credential file is provided. Change the code to try to look for external credentials in case of any error in the previous code block. Signed-off-by: Simo Sorce <[email protected]>
|
@frozencemetery the changes have been QAd by @kvv81 (see comment in #41), so they are redy for final review. |
frozencemetery
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a creedntial store is provide but no name is provided we end up
crashing by dereferencing the name.
Allow the request to proceed without a name, as it may be selected out
of a credential file, but if none was found, return an error.
Fixes #40
Fixes #42