-
-
Notifications
You must be signed in to change notification settings - Fork 190
Improve texture builder APIs #2046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/windows-msvc.yml
Outdated
@@ -75,7 +75,7 @@ jobs: | |||
working-directory: /gtk | |||
if: steps.cache.outputs.cache-hit != 'true' | |||
run: | | |||
meson setup builddir --prefix=C:/gnome -Dbackend_max_links=1 -Dbuild-demos=false -Dbuild-tests=false -Dvulkan=disabled -Dmedia-gstreamer=disabled -Dbuild-examples=false -Dglib:tests=false -Dharfbuzz:tests=disabled -Dharfbuzz:docs=disabled -Dgraphene:tests=false -Dgdk-pixbuf:tests=false -Dcairo:tests=disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will probably break the msvc build but let us hope not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's broken completely anyway 🙃
Please rebase, that should fix the CI. We can merge afterwards |
Windows things still don't pass but rebased otherwise :) |
it does pass on main, it is caused by
and other errors ;-) |
The whole DMABufTextureBuilder should be gated by cfg(linux) anyways |
Oh indeed, sorry |
Needs gtk-rs/gir#1652 |
…nsafe The fd must be valid for as long as the texture stays around, which can't be statically guaranteed and is job of the user, e.g. by using the release function. And use Borrowed fd for getter.
CC @rmader