🌱 [main] update client/openapi/trustd.yaml#1007
Merged
carlosthe19916 merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Reviewer's GuideUpdates the generated Trustd OpenAPI client specification to version 0.5.0-beta.2 and adds a new paginated /api/v2/sbom/models search endpoint for AI models, including rich query, sorting, and pagination parameters. Sequence diagram for the new /api/v2/sbom/models AI model search endpointsequenceDiagram
actor ApiConsumer
participant ClientSdk
participant TrustdApi
ApiConsumer->>ClientSdk: listAllModels(q, sort, offset, limit)
ClientSdk->>TrustdApi: GET /api/v2/sbom/models?q&sort&offset&limit
TrustdApi-->>ClientSdk: 200 PaginatedResults_SbomModel
ClientSdk-->>ApiConsumer: Paginated SbomModel list with metadata
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
q,sort,offset, andlimitquery parameter definitions appear to duplicate patterns used elsewhere; consider extracting them into reusablecomponents.parametersentries to avoid drift and keep the spec DRY. - The new
/api/v2/sbom/modelsendpoint is taggedsbombut described as listing AI models; verify that the tag and summary/description align with the intended domain to avoid confusion for API consumers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `q`, `sort`, `offset`, and `limit` query parameter definitions appear to duplicate patterns used elsewhere; consider extracting them into reusable `components.parameters` entries to avoid drift and keep the spec DRY.
- The new `/api/v2/sbom/models` endpoint is tagged `sbom` but described as listing AI models; verify that the tag and summary/description align with the intended domain to avoid confusion for API consumers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
- Coverage 68.41% 66.83% -1.59%
==========================================
Files 223 223
Lines 3920 3920
Branches 910 910
==========================================
- Hits 2682 2620 -62
- Misses 887 953 +66
+ Partials 351 347 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carlosthe19916
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openapi.yaml of trustify has changed
Summary by Sourcery
Update trustd OpenAPI specification with a new SBOM models listing endpoint and version bump.
New Features:
Enhancements: