Conversation
Contributor
Author
|
I haven't figured out how to make it look at tsx, ts and js files yet. |
Contributor
|
I think in the makefile you'll need to tell ESLint to look for those extensions using |
Contributor
Author
|
I'm getting a lot of |
Contributor
|
|
Contributor
Author
|
I would really have expected either the plugin or the parser to have automated/documented this. (Also the extensions) |
Contributor
|
Yeah, I'd say it's more the plugin's responsibility. I think there's a question mark hanging over how well maintained the plugin is. |
Contributor
Author
|
alas poor eslint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
How about we used eslint instead of #159 ?
Why?