Skip to content

Comments

eslint#160

Closed
AWare wants to merge 3 commits intomasterfrom
eslint
Closed

eslint#160
AWare wants to merge 3 commits intomasterfrom
eslint

Conversation

@AWare
Copy link
Contributor

@AWare AWare commented Sep 4, 2018

What does this change?

How about we used eslint instead of #159 ?

Why?

@AWare
Copy link
Contributor Author

AWare commented Sep 4, 2018

I haven't figured out how to make it look at tsx, ts and js files yet.

@AWare AWare added question 🥒WiP Work in Progress labels Sep 4, 2018
@SiAdcock
Copy link
Contributor

SiAdcock commented Sep 4, 2018

I think in the makefile you'll need to tell ESLint to look for those extensions using --ext .ts,.tsx,.js

@AWare
Copy link
Contributor Author

AWare commented Sep 4, 2018

I'm getting a lot of no-undef for type definitions.

@SiAdcock
Copy link
Contributor

SiAdcock commented Sep 4, 2018

no-undef is not an applicable linting rule since the TypeScript compiler errors if you reference an undefined variable. The workaround is to disable the rule on TypeScript files.

@AWare
Copy link
Contributor Author

AWare commented Sep 4, 2018

I would really have expected either the plugin or the parser to have automated/documented this. (Also the extensions)

@SiAdcock
Copy link
Contributor

SiAdcock commented Sep 4, 2018

Yeah, I'd say it's more the plugin's responsibility. I think there's a question mark hanging over how well maintained the plugin is.

@AWare
Copy link
Contributor Author

AWare commented Sep 6, 2018

alas poor eslint

@AWare AWare closed this Sep 6, 2018
@gtrufitt gtrufitt deleted the eslint branch August 9, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question 🥒WiP Work in Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants