Upgrade Typescript to 5.x and related dependencies #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As caught errors are now of type unknown
jonathonherbert
force-pushed
the
jsh/bump-deps
branch
2 times, most recently
from
c7ebca8 to
e025d89
Compare
jonathonherbert
commented
Mar 1, 2024
| import path from 'path'; | ||
| import common from './webpack.config.common.js'; | ||
| const path = require('path'); | ||
| const common = require('./webpack.config.common.js'); |
There was a problem hiding this comment.
We should not be mixing and matching import styles here, so I've moved all webpack config to CommonJS.
jonathonherbert
force-pushed
the
jsh/bump-deps
branch
from
558f899 to
a330a6a
Compare
…ides for react-router-redux, which imports old and incompatible redux types In future we should consider whether we need this module, and if so migrate to https://github.com/supasate/connected-react-router
jonathonherbert
force-pushed
the
jsh/bump-deps
branch
from
a330a6a to
c2ad35c
Compare
To thread the needle between puppeteer (16+) and webpack 4 (<18)
…causing crashes hopefully we can catch these errors and treat them as special cases
Fweddi
approved these changes
Mar 5, 2024
|
Seen on PROD (merged by @jonathonherbert 11 minutes and 35 seconds ago) Please check your changes! |
jonathonherbert
added a commit
that referenced
this pull request
Mar 6, 2024
jonathonherbert
added a commit
that referenced
this pull request
Mar 6, 2024
jonathonherbert
added a commit
that referenced
this pull request
Mar 20, 2024
jonathonherbert
added a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Bumps Typescript and Jest, in preparation for Vite.
As a result of changes in types, this means bumping a few other packages and/or their types, including eslint, react, redux and their bindings, and styled-components.
Because the linting style of eslint and its typescript plugin has changed, we must also include a large
lint --fixas part of this PR. I've isolated that to a single commit to make it easier to tell apart the linting no-op from other changes.Implementation notes
This is a large PR! I've tried to make sure the commits tell the story. Happy to pair to review.
There are very few runtime changes outside of those versions – I've kept them scoped to 662fd39 to make them easier to identify in case of problems.
Worth noting that we have good integration tests on this project for card rendering, drag and drop, etc. that should give us some confidence things are working as expected.
Checklist
General
Client