Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't poll every second for switchboard changes #1583

Merged
merged 1 commit into from
May 15, 2024
Merged

Don't poll every second for switchboard changes #1583

merged 1 commit into from
May 15, 2024

Conversation

jonathonherbert
Copy link
Contributor

What's changed?

Seems excessive. Suspect inadvertently introduced in #1543. Spotting as local was busily logging.

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@jonathonherbert jonathonherbert requested a review from a team as a code owner May 15, 2024 16:19
@github-actions GitHub Actions
Copy link

Deploy build 8061 of cms-fronts::facia-tool to CODE

All deployment options

From guardian/actions-riff-raff.

davidfurey
davidfurey approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@davidfurey davidfurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈
Good spot

@jonathonherbert jonathonherbert merged commit 1a7dee7 into main May 15, 2024
9 checks passed
@jonathonherbert jonathonherbert deleted the jsh/be-cool-about-switches-1 branch May 15, 2024 17:05
@prout-bot
Copy link

Seen on PROD (merged by @jonathonherbert 7 minutes and 32 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfurey davidfurey davidfurey approved these changes

Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathonherbert @prout-bot @davidfurey