Handle the move of suppressImages to displayHints #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fweddi
force-pushed
the
fp/handle-suppress-images-move
branch
from
ba5edcb to
9f95787
Compare
Fweddi
force-pushed
the
fp/handle-suppress-images-move
branch
from
9f95787 to
5a1d19f
Compare
Co-authored-by: David Furey <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
In guardian/facia-scala-client#342 we moved the
suppressImagesfield to DisplayHints in order to free up the Case Class limit on the CollectionConfig. This PR handles that change in the Fronts Tool.Testing
In the Fronts config, using a Beta container, check the
suppressImagescheckbox. Refresh the config page. The field should persist.Navigate to the Fronts Tool proper and open a front with the relevant container. You should see
Images suppressedappear at the top of the container:Uncheck the checkbox in the config; refresh, the
Images suppressedlabel should disappear in the Fronts tool.Ideally this should hide the images for the given container on the CODE front. It currently does not, which I assume is because we need to update the platforms to support the new facia model. Although this is a breaking change, beta containers are not currently in production, so I think we are okay to fix forward.