Allow each group to have different maxItems #1763
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fweddi
commented
Feb 21, 2025
| @@ -83,7 +83,7 @@ libraryDependencies ++= Seq( | |||
| "com.gu" %% "content-api-client-aws" % "0.7.6", | |||
| "com.gu" %% "content-api-client-default" % capiClientVersion, | |||
| "com.gu" %% "editorial-permissions-client" % "3.0.0", | |||
| "com.gu" %% "fapi-client-play30" % "15.0.0", | |||
| "com.gu" %% "fapi-client-play30" % "16.0.0-PREVIEW.fpadd-groups-config-field.2025-02-21T1227.15f48131", | |||
There was a problem hiding this comment.
Will need to swap out for 16.0.0 once guardian/facia-scala-client#345 is released.
Fweddi
force-pushed
the
fp/max-items-per-group
branch
from
564bf14 to
9f359da
Compare
Fweddi
commented
Feb 21, 2025
app/model/frontsapi.scala
Outdated
| @@ -421,8 +421,8 @@ trait UpdateActionsTrait extends Logging { | |||
| collectionId: String, | |||
There was a problem hiding this comment.
I'm confused about the relation between the config groups field and the trail metadata group field.
abeddow91
reviewed
Feb 25, 2025
| id: 'exampleCollection', | ||
| displayName: 'Example Collection', | ||
| type: 'any', | ||
| groups: ['large', 'medium', 'small'], |
There was a problem hiding this comment.
Existing/legacy containers have a concept of groups. Is the plan to move to groupsConfig for all containers rather than just for "beta" containers? If so, will that require us to repress all fronts?
There was a problem hiding this comment.
ahh ignore the above, i see that we're supporting both here https://github.com/guardian/facia-scala-client/pull/345/files 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Implementation notes
Checklist
General
Client