Improve logging with requestId #27804
Draft
+108
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjisound
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds
RequestIdFilterto the filters of theadminapplication. This filter ensures that thex-gu-xidheader is added to incoming requests.Additionally, I introduced new functions in GuLogging that take an implicit request parameter. These functions attempt to retrieve the
x-gu-xidfrom request headers and include it as the requestId field in logs.Using these new functions, I updated nearly all logs generated during the request journey. I say "nearly all" because, in the frontend, many logs are produced via agents or background jobs, which are outside the request flow. I’ve done my best to capture all logs within the request journey, but I may have missed some.