Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy to clipboard option to workspace context menu #188

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

philmcmahon
Copy link
Contributor

@philmcmahon philmcmahon commented Dec 21, 2023

What does this change?

This adds two new context menu options to the workspace view in giant - 'Copy file name' and 'Copy file path'

They look like this:

Screen.Recording.2023-12-21.at.16.07.50.mov

How to test

Tested on playground and locally. There's a recursive function used to generate the file path, maybe it should have some tests? We actually don't appear to have any client side tests in giant so that feels a bit of a stretch

@philmcmahon philmcmahon requested a review from a team as a code owner December 21, 2023 16:10
@philmcmahon philmcmahon merged commit b6bef38 into main Dec 22, 2023
1 check passed
@philmcmahon philmcmahon deleted the pm-copy-clipboard branch December 22, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants