Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix transcript and extractText download #189

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix transcript and extractText download #189

merged 1 commit into from
Jan 3, 2024

Conversation

marjisound
Copy link
Contributor

@marjisound marjisound commented Jan 2, 2024 •
edited
Loading

What does this change?

This PR does the following:

  • Fixes the extractedText download. the actual text is within the contents field within the text object. The existing code was trying to get the text string from the text itself.
  • Fixes the transcript download. The transcript download was added as a new download type so that depending on which transcript language the user picks, it would download the relevant language text file.

ezgif-1-522aa3e19e

How to test

@hoyla
Copy link
Contributor

hoyla commented Jan 2, 2024

Awesome!

@marjisound marjisound marked this pull request as ready for review January 3, 2024 08:35
@marjisound marjisound requested a review from a team as a code owner January 3, 2024 08:35
philmcmahon
philmcmahon approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@philmcmahon philmcmahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@marjisound marjisound merged commit c2574ce into main Jan 3, 2024
1 check passed
@marjisound marjisound deleted the fix-transcript-download branch January 3, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philmcmahon philmcmahon philmcmahon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marjisound @hoyla @philmcmahon