Stop hand-rolling RepocopVulnerability type #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NovemberTang
force-pushed
the
nt/vuln-type
branch
from
ffea749 to
574d273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove the need to hand-roll a
RepocopVulnerabilitytype. Derive one from therepocop_vulnerabilitiesinterface provided by prismaWhy?
Maintainability. This is part of a larger piece of work to simplify vulnerability calculations in repocop
How has it been verified?
All unit tests still pass, local execution of repocop produces the same output as CODE