Explicitly version node and prisma in the migrate image
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislomaxjones
force-pushed
the
clj/tweak-prisma-migrate-image
branch
from
958af7d to
689f79f
Compare
chrislomaxjones
force-pushed
the
clj/tweak-prisma-migrate-image
branch
4 times, most recently
from
220792c to
7e0ef79
Compare
chrislomaxjones
force-pushed
the
clj/tweak-prisma-migrate-image
branch
from
7e0ef79 to
6652bf0
Compare
|
This will require a subsequent PR bumping the commit hash, such as #883. |
akash1810
approved these changes
Mar 27, 2024
Comment on lines
+12
to
+13
| # TODO: Keep the version automatically in sync with common/package.json | ||
| RUN npm install [email protected] |
There was a problem hiding this comment.
Suspect this'll get annoying very quickly as Dependabot updates Prisma every week...
There was a problem hiding this comment.
Good point 👍
Simplest route might be to just COPY ./packages/common/package.json ... and RUN npm install. A multi-stage build could be used to drop all of the dependencies we don't care about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
node:20.11.1-alpineimage, which matches the.nvmrc.[email protected], which matches the rest of the service-catalogue (specificallypackages/common/package.json).Thanks @akash1810 for the heads up.
Why?
The versions of software used in the image should be the same as those used in the rest of the repo.
How has it been verified?
Tested on CODE via #883